Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update oauth-proxy and kube-rbac-proxy gateway images #1754

Closed
wants to merge 1 commit into from

Conversation

dkwon17
Copy link
Contributor

@dkwon17 dkwon17 commented Sep 12, 2023

What does this PR do?

Updates the oauth-proxy and kube-rbac-proxy gateway images from the che-gateway pod.

I based this update on a previous update done here: 7d6dcbd

Screenshot/screencast of this PR

image

What issues does this PR fix or reference?

PR made in response to eclipse-che/che#22353

How to test this PR?

  1. Checkout this PR branch, and run ./build/scripts/olm/test-catalog-from-sources.sh to install Eclipse Che on a cluster
  2. Verify that the oauth-proxy and kube-rbac-proxy images are quay.io/openshift/origin-oauth-proxy:4.15 and quay.io/openshift/origin-kube-rbac-proxy:4.15 respectively :
$ oc get deployment che-gateway -n eclipse-che  -o jsonpath='{.spec.template.spec.containers[*].image}'

<traefik-image> <configbump-image> quay.io/openshift/origin-oauth-proxy:4.15 quay.io/openshift/origin-kube-rbac-proxy:4.15
  1. Verify that you can visit the Che dashboard and start a workspace without any errors.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: dkwon17 <dakwon@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Sep 12, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dkwon17

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dkwon17
Copy link
Contributor Author

dkwon17 commented Sep 12, 2023

I unfortunately still experience 401/403 errors even with the updated gateway images:

image image

@dkwon17
Copy link
Contributor Author

dkwon17 commented Sep 22, 2023

Needs further testing, I received websocket connection error from the dashboard the last time I tested the new images

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Jan 15, 2024

@dkwon17: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-devworkspace-happy-path 3c2fda1 link true /test v14-devworkspace-happy-path
ci/prow/v14-operator-test 3c2fda1 link true /test v14-operator-test
ci/prow/v14-upgrade-stable-to-next 3c2fda1 link true /test v14-upgrade-stable-to-next
ci/prow/v14-che-behind-proxy 3c2fda1 link true /test v14-che-behind-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dkwon17
Copy link
Contributor Author

dkwon17 commented Jan 15, 2024

Closing since this PR is not absolutely necessary for now

@dkwon17 dkwon17 closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants