Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore empty editor definitions #1892

Merged
merged 2 commits into from
Sep 5, 2024
Merged

fix: Ignore empty editor definitions #1892

merged 2 commits into from
Sep 5, 2024

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Sep 4, 2024

What does this PR do?

fix: Ignore empty editor definitions

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#23087

How to test this PR?

  1. Prepare a patch file if needed:
cat > /tmp/cr-patch.yaml <<EOF
apiVersion: org.eclipse.che/v2
kind: CheCluster
spec: {}
EOF
  1. Deploy the operator:

OpenShift

./build/scripts/olm/test-catalog-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

on Minikube

./build/scripts/minikube-tests/test-operator-from-sources.sh --cr-patch-yaml /tmp/cr-patch.yaml

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Copy link

openshift-ci bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Copy link

openshift-ci bot commented Sep 4, 2024

@tolusha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-che-behind-proxy 4f2f5be link true /test v14-che-behind-proxy

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tolusha
Copy link
Contributor Author

tolusha commented Sep 5, 2024

/test v14-devworkspace-happy-path

@tolusha tolusha merged commit 9c3c4d9 into main Sep 5, 2024
20 of 21 checks passed
@tolusha tolusha deleted the 23087 branch September 5, 2024 09:06
@devstudio-release
Copy link

Build 3.17 :: operator_3.x/393: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.17 :: operator_3.x/393: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7682 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.17 :: copyIIBsToQuay/2780: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: sync-to-downstream_3.x/7683: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7674 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.17 :: operator-bundle_3.x/3606: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7683 triggered

@devstudio-release
Copy link

Build 3.17 :: dsc_3.x/1988: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.17 :: update-digests_3.x/7485: SUCCESS

Detected new images: rebuild operator-bundle
* devspaces-operator; /DS_CI/operator-bundle_3.x/3606 triggered

@devstudio-release
Copy link

Build 3.17 :: dsc_3.x/1988: SUCCESS

3.17.0-CI

@devstudio-release
Copy link

Build 3.17 :: copyIIBsToQuay/2780: SUCCESS

3.17
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.17-3
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:???
+ s390x-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.17-v4.16-806805- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.17-v4.16-806805- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.17-v4.16-s390x
  + <a href=https://quay.io/devspaces/iib:3.17-v4.15-806804- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.17-v4.15-806804- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.17-v4.15-s390x
  + <a href=https://quay.io/devspaces/iib:3.17-v4.14-806802- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.17-v4.14-806802- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.17-v4.14-s390x
  + <a href=https://quay.io/devspaces/iib:3.17-v4.13-806801- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.17-v4.13-806801- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.17-v4.13-s390x
  + <a href=https://quay.io/devspaces/iib:3.17-v4.12-806800- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.17-v4.12-806800- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.17-v4.12-s390x
+ x86_64-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.17-v4.16-806805- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.17-v4.16-806805- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.17-v4.16-x86_64
  + <a href=https://quay.io/devspaces/iib:3.17-v4.15-806804- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.17-v4.15-806804- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.17-v4.15-x86_64
  + <a href=https://quay.io/devspaces/iib:3.17-v4.14-806802- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.17-v4.14-806802- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.17-v4.14-x86_64
  + <a href=https://quay.io/devspaces/iib:3.17-v4.13-806801- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.17-v4.13-806801- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.17-v4.13-x86_64
  + <a href=https://quay.io/devspaces/iib:3.17-v4.12-806800- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.17-v4.12-806800- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.17-v4.12-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.17-v4.16-806805- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.17-v4.16-806805- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.17-v4.16-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.17-v4.15-806804- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.17-v4.15-806804- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.17-v4.15-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.17-v4.14-806802- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.17-v4.14-806802- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.17-v4.14-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.17-v4.13-806801- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.17-v4.13-806801- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.17-v4.13-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.17-v4.12-806800- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.17-v4.12-806800- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.17-v4.12-ppc64le

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants