-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ignore empty editor definitions #1892
Conversation
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tolusha: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/test v14-devworkspace-happy-path |
Build 3.17 :: operator_3.x/393: Console, Changes, Git Data |
Build 3.17 :: sync-to-downstream_3.x/7682: Console, Changes, Git Data |
Build 3.17 :: push-latest-container-to-quay_3.x/4911: Console, Changes, Git Data |
Build 3.17 :: get-sources-rhpkg-container-build_3.x/7672: devspaces-operator : 3.x :: Build 63981262 : quay.io/devspaces/devspaces-rhel8-operator:3.17-7 |
Build 3.17 :: update-digests_3.x/7485: Console, Changes, Git Data |
Build 3.17 :: operator_3.x/393: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7682 triggered |
Build 3.17 :: operator-bundle_3.x/3606: Console, Changes, Git Data |
Build 3.17 :: sync-to-downstream_3.x/7683: Console, Changes, Git Data |
Build 3.17 :: push-latest-container-to-quay_3.x/4912: Console, Changes, Git Data |
Build 3.17 :: copyIIBsToQuay/2780: Console, Changes, Git Data |
Build 3.17 :: sync-to-downstream_3.x/7683: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7674 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.17 :: operator-bundle_3.x/3606: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7683 triggered |
Build 3.17 :: dsc_3.x/1988: Console, Changes, Git Data |
Build 3.17 :: update-digests_3.x/7485: Detected new images: rebuild operator-bundle |
Build 3.17 :: dsc_3.x/1988: 3.17.0-CI |
Build 3.17 :: copyIIBsToQuay/2780: 3.17 |
What does this PR do?
fix: Ignore empty editor definitions
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#23087
How to test this PR?
OpenShift
on Minikube
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.