Duplicate Dockerfile in the build directory #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
tolusha
requested review from
davidfestal,
l0rd,
nickboldt,
rhopp and
vparfonov
as code owners
45 tasks
AndrienkoAleksandr
approved these changes
Mar 20, 2020
For some operations(debug), for operator sdk is ok even an empty dockerfile... |
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
|
Agree. It is better make it empty. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatoliy Bazko abazko@redhat.com
Reference issue
eclipse-che/che#16206
What does this PR do
For some tasks
operator-sdkrequiresDockerfileto be located intobuilddirectory otherwise it fails with the error:FATA[0000] must run command in project root dir: project structure requires build/DockerfileI don't want to remove it from the root of the project since it is used by some build jobs.
Duplication it is enough for operator-sdk