Add Che CR validator #221
Merged
Add Che CR validator #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
mmorhun
requested review from
davidfestal,
tolusha,
sleshchenko and
AndrienkoAleksandr
mmorhun
requested review from
l0rd,
nickboldt,
rhopp and
vparfonov
as code owners
43 tasks
tolusha
reviewed
Apr 15, 2020
tolusha
reviewed
Apr 15, 2020
tolusha
reviewed
Apr 15, 2020
tolusha
reviewed
Apr 15, 2020
tolusha
reviewed
Apr 15, 2020
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
AndrienkoAleksandr
approved these changes
Apr 15, 2020
tolusha
approved these changes
Apr 16, 2020
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Morhun mmorhun@redhat.com
What this PR does
This PR adds simple validation of Che CR at the beginning of reconcile loop. If an mistake found in the CR, corresponding message will be printed into Operator logs and it will wait till CR is changed.
For now it checks very basic things, like ingress domain for Kubernetes, but could be easily extended for other cases.
Which issues this PR references
I ran into issue that Che operator may fall into infinite reconcile loop if some fields of CR are misconfigured. It wasn't fault of reconcile logic as it is just required to have some fields specified.
So this is additional changes in terms of #220