Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create CI scripts to test new nightly bundles using new Openshift CI bundles workflow #564

Merged
merged 15 commits into from
Dec 11, 2020
Merged

Conversation

flacatus
Copy link
Contributor

@flacatus flacatus commented Dec 4, 2020

Reff issue: eclipse-che/che#18293

Signed-off-by: Flavius Lacatusu flacatus@redhat.com

Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@flacatus
Copy link
Contributor Author

flacatus commented Dec 9, 2020

/test ?

@openshift-ci-robot
Copy link

@flacatus: The following commands are available to trigger jobs:

  • /test v6-che-operator-olm-nightly-deployment
  • /test v6-che-operator-single-host-nightly-deployment
  • /test v6-ci-index
  • /test v6-images
  • /test v7-che-operator-olm-nightly-deployment
  • /test v7-che-operator-single-host-nightly-deployment
  • /test v7-ci-index
  • /test v7-images

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flacatus
Copy link
Contributor Author

flacatus commented Dec 9, 2020

/test all

@flacatus
Copy link
Contributor Author

flacatus commented Dec 9, 2020

/retest

@tolusha
Copy link
Contributor

tolusha commented Dec 9, 2020

Some general remarks:

  • .ci/common.sh isn't needed, we have .github/bin/common.sh
  • pls refactor .ci/oci-single-host.sh and .ci/oci-nightly-olm.sh like .ci/cico_openshift_shost.sh

Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@tolusha
Copy link
Contributor

tolusha commented Dec 10, 2020

olm/testCatalogSource.sh script is mentioned in olm/README.md file
Will it work after the changes ?

@@ -9,6 +9,7 @@
#
# Contributors:
# Red Hat, Inc. - initial API and implementation
set -ex

# Minikube environments config
export MINIKUBE_VERSION=v1.8.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it too old ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm changing the minikube version in stable tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be a separate PR

@flacatus
Copy link
Contributor Author

flacatus commented Dec 10, 2020

olm/testCatalogSource.sh script is mentioned in olm/README.md file
Will it work after the changes ?

I can test and it is working

Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
export OPERATOR_REPO=$(dirname $(dirname $(readlink -f "$0")));
source "${OPERATOR_REPO}"/.github/bin/common.sh

#Stop execution on any error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: #Stop -> # Stop

Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive job!

Signed-off-by: Flavius Lacatusu <flacatus@redhat.com>
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AndrienkoAleksandr, flacatus, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flacatus flacatus merged commit 335c6ff into eclipse-che:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants