Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add liveness and readiness probes #598

Merged
merged 1 commit into from
Dec 30, 2020
Merged

Add liveness and readiness probes #598

merged 1 commit into from
Dec 30, 2020

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Dec 29, 2020

Signed-off-by: Anatolii Bazko abazko@redhat.com

Reference issue

https://issues.redhat.com/browse/CRW-683
https://issues.redhat.com/browse/CRW-916

What does this PR do

  • add liveness and readiness probes for operator
  • add liveness probe for keycloak and postgres containers

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Copy link
Contributor Author

tolusha commented Dec 29, 2020

/retest

1 similar comment
@tolusha
Copy link
Contributor Author

tolusha commented Dec 30, 2020

/retest

@openshift-merge-robot
Copy link

@tolusha: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v7-che-operator-single-host-nightly-deployment 0ed6d7e link /test v7-che-operator-single-host-nightly-deployment
ci/prow/v6-che-operator-single-host-nightly-deployment 0ed6d7e link /test v6-che-operator-single-host-nightly-deployment
ci/prow/v7-che-operator-olm-nightly-deployment 0ed6d7e link /test v7-che-operator-olm-nightly-deployment
ci/prow/v6-che-operator-olm-nightly-deployment 0ed6d7e link /test v6-che-operator-olm-nightly-deployment

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tolusha
Copy link
Contributor Author

tolusha commented Dec 30, 2020

OpenShift tests fail due to fact that it tries to use the quay.io/eclipse/che-operator:nightly image where readiness and liveness probes aren't added.

@tolusha
Copy link
Contributor Author

tolusha commented Dec 30, 2020

Tested locally on OpenShift, it works fine.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorhun, sleshchenko, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit 39b7a1e into master Dec 30, 2020
@tolusha tolusha deleted the probes branch December 30, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants