Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify resources limits #612

Merged
merged 10 commits into from
Jan 25, 2021
Merged

Specify resources limits #612

merged 10 commits into from
Jan 25, 2021

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jan 6, 2021

Signed-off-by: Anatolii Bazko abazko@redhat.com

Reference issue

eclipse-che/che#18356

What does this PR do

Adds limits to containers.

@openshift-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tolusha tolusha mentioned this pull request Jan 6, 2021
79 tasks
pkg/deploy/defaults.go Outdated Show resolved Hide resolved
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha marked this pull request as ready for review January 20, 2021 10:10
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #612 (3df6611) into master (b1a756d) will increase coverage by 12.97%.
The diff coverage is 60.46%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #612       +/-   ##
===========================================
+ Coverage   14.24%   27.21%   +12.97%     
===========================================
  Files          37       43        +6     
  Lines        4247     4651      +404     
===========================================
+ Hits          605     1266      +661     
+ Misses       3503     3214      -289     
- Partials      139      171       +32     
Impacted Files Coverage Δ
pkg/util/test_util.go 0.00% <0.00%> (ø)
pkg/util/util.go 11.69% <0.00%> (-0.21%) ⬇️
pkg/deploy/plugin-registry/deployment.go 77.50% <70.37%> (ø)
pkg/deploy/devfile-registry/deployment.go 77.50% <71.42%> (ø)
pkg/deploy/postgres/deployment_postgres.go 73.09% <92.30%> (ø)
pkg/deploy/server/deployment_che.go 62.41% <92.30%> (+62.41%) ⬆️
...kg/deploy/identity-provider/deployment_keycloak.go 49.91% <93.33%> (+49.91%) ⬆️
pkg/deploy/defaults.go 45.83% <100.00%> (+0.37%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1a756d...3df6611. Read the comment docs.

@flacatus
Copy link
Contributor

/test ?

@tolusha
Copy link
Contributor Author

tolusha commented Jan 21, 2021

/test

@droslean
Copy link

/refresh
/test all

@flacatus
Copy link
Contributor

/test all

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Copy link
Contributor

@mmorhun mmorhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

resources allowed.
properties:
cpu:
description: CPU, in cores. (500m = .5 cores)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and further: please specify full form like 0.5 instead of .5. It is easier to read.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is copy/paste from go docs of the corresponding object.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorhun, tolusha
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorhun mmorhun removed their assignment Jan 25, 2021
@tolusha tolusha changed the title Specify limits Specify resorces limits Jan 25, 2021
@tolusha tolusha changed the title Specify resorces limits Specify resources limits Jan 25, 2021
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@tolusha tolusha merged commit d5ea65a into master Jan 25, 2021
@tolusha tolusha deleted the limits branch January 25, 2021 11:48
@che-bot che-bot added this to the 7.25 milestone Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants