-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify resources limits #612
Conversation
Skipping CI for Draft Pull Request. |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #612 +/- ##
===========================================
+ Coverage 14.24% 27.21% +12.97%
===========================================
Files 37 43 +6
Lines 4247 4651 +404
===========================================
+ Hits 605 1266 +661
+ Misses 3503 3214 -289
- Partials 139 171 +32
Continue to review full report at Codecov.
|
/test ? |
/test |
/refresh |
/test all |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
resources allowed. | ||
properties: | ||
cpu: | ||
description: CPU, in cores. (500m = .5 cores) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and further: please specify full form like 0.5
instead of .5
. It is easier to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is copy/paste from go docs of the corresponding object.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
New changes are detected. LGTM label has been removed. |
Signed-off-by: Anatolii Bazko abazko@redhat.com
Reference issue
eclipse-che/che#18356
What does this PR do
Adds limits to containers.