Che Operator Security Context Defined Posture Parameters #811
Conversation
ArvinB
requested review from
AndrienkoAleksandr,
flacatus,
mmorhun,
nickboldt and
tolusha
as code owners
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ArvinB, nickboldt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It would seem that most PRs are failing to pass the |
|
Changes in I assume that the target platform of this changes is OpenShift and deployment method is olm.
[1] https://github.com/eclipse-che/che-operator/blob/main/olm/update-resources.sh#L192-L221 |
per @tolusha recommendation, I'm delivering: [X] Remove runAsNonRoot and allowPrivilegeEscalation from operator.yaml [X] Revert all other changes in csv files. [X] If we need something specifically for OpenShift then let's update OpenShift csv file like here [1] [1] https://github.com/eclipse-che/che-operator/blob/main/olm/update-resources.sh#L192-L221
|
@tolusha I completed your recommendation. I assume running:
...is for testing purposes only? I was able to successfully generate the csv files, but I did not deliver them into this PR? Thanks. |
pls add them to the PR. |
|
@tolusha Update the PR thank you. |
@tolusha Updates made based on your feedback. Again thank you very much!
|
/retest |
|
@tolusha Good to merge? |
|
@ArvinB |
|
We can ignore minikube tests for now, they are known problem. [1] 416f78b#diff-82b7ba34bc00ed0fcaa5f46c8eea16961909f41152e2477c016195ac74b66729R227-R229 |
Changes made @tolusha |
|
|
|
@tolusha Done. However, I get a conflict after pushing in your requested changes. Any suggestions? |
|
No problem. Resolve conflicts by taking your changes. |
|
/retest |
|
/test v7-devworkspace-happy-path |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ArvinB, nickboldt, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test v7-devworkspace-happy-path |
What does this PR do?
It fully declares the
securityContextunder operator PodScreenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#19737
How to test this PR?
Tested on OpenShift 4.7.8 using Wazi Developer for Workspaces 1.2.5 (based on Red Hat CodeReady Workspaces 2.7 (Che 7.26)).
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.