-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add an ability to add localhost to allows list for keycloak #937
feat: add an ability to add localhost to allows list for keycloak #937
Conversation
Skipping CI for Draft Pull Request. |
fd30de1
to
811ed12
Compare
reworked after debug command is moved to Makefile. |
/retest |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sleshchenko, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
It's a draft since some of the corner cases are not tested yet.
The purpose of this PR is adding an ability to add localhost to allow list for keycloak,
but since such kind of data is not secret, it also add a mechanism for mounting additional configmap into deployment.
It's just a copying/pasting mechanism we have for secrets, sorry about that, I did not manage to prepare the better solution in my Hack&Hustle.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
it solves eclipse-che/che#19158
How to test this PR?
I did the following two stories
https://github.com/eclipse-che/che-operator/blob/main/pkg/deploy/identity-provider/identity_provider.go#L134
@tolusha is aware of it and is OK to move it out of the scope. Probably it needs to introducing one more field into status.
Test provision/update scripts with missing custom settings, and then update script with custom settings
Test provision/update scripts with custom settings
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.