fix: Don't ignore restore status error. I hope it will make restore feature more stable. #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrienkoAleksandr
requested review from
flacatus,
mmorhun,
nickboldt and
tolusha
as code owners
AndrienkoAleksandr
changed the title
tolusha
approved these changes
Jul 18, 2021
…e more stable. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
tolusha
force-pushed
the
dontIgnoreRestoreStatusError
branch
from
319e8f4 to
986930a
Compare
|
/test v8-che-behind-proxy |
1 similar comment
|
/test v8-che-behind-proxy |
Codecov Report
@@ Coverage Diff @@
## main #941 +/- ##
=======================================
Coverage 49.93% 49.93%
=======================================
Files 56 56
Lines 6628 6628
=======================================
Hits 3310 3310
Misses 2964 2964
Partials 354 354 Continue to review full report at Codecov.
|
tolusha
approved these changes
Jul 21, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Don't ignore restore status error. I hope it will make restore feature more stable.
What issues does this PR fix or reference?
None. But ci fails very often. Looks like restore feature is unstable.
How to test this PR?
N/A
PR Checklist
N/A
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com