This repository has been archived by the owner on Jan 20, 2023. It is now read-only.
Propagate id and version to Che Server #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @l0rd |
mshaposhnik
approved these changes
Nov 19, 2018
|
@sleshchenko @skabashnyuk just keep in mind that I am working on eclipse-che/che-plugin-registry#63 |
skabashnyuk
reviewed
Nov 20, 2018
There was a problem hiding this comment.
The code is ok for me. But I would like to see some tests with the code as well. Up to @garagatyi and @sleshchenko to decide if we can merge this pr without a test.
guys wdyt?
sleshchenko
force-pushed
the
idVersionPropagation
branch
from
021961f to
e495945
Compare
|
@skabashnyuk Added tests for setStatus/addTolling/Tolling methods in Storage. I think my changes really affects only these places. Please approve if you OK with that. |
skabashnyuk
approved these changes
Nov 20, 2018
sleshchenko
force-pushed
the
idVersionPropagation
branch
from
4b09476 to
4fff030
Compare
garagatyi
approved these changes
Nov 20, 2018
4 tasks
metlos
pushed a commit
to metlos/che-plugin-broker
that referenced
this pull request
Jun 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds propagating of id and version field to Che Server.
Che Server parses objects published by Plugin Broker as Che Plugins which has id, version and name field. But previosly Plugin Broker didn't publish id, version and name fields and Che Server doesn't have an ability to match received configuration with Che Plugin. It may be needed like for resolving Che Plugin Commands, or containers names evaluation.
This PR doesn't add propagation of Che Plugin name because Che 7 workspace won't work since names of some of plugins doesn't suite name format which Che Server requires. Example of such plugin https://github.com/eclipse/che-plugin-registry/blob/master/plugins/che-machine-exec-plugin/0.0.1/meta.yaml#L4
So, propagation of plugin name should be uncommented when eclipse-che/che#11479 will be fixed.
What issues does this PR fix or reference?
It is related to eclipse-che/che#9546