This repository has been archived by the owner on Jan 20, 2023. It is now read-only.
Fix mistake in usage of append and update Makefile and sample config. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
metlos
pushed a commit
to metlos/che-plugin-broker
that referenced
this pull request
Jun 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I updated PR #40 to use
appendinstead of setting indices directly, but forgot to update the length when making the slice, which results in default elements occupying the first half of the array.Also updates makefile and
config-plugin-ids.jsonto not use/pluginsas part of the registry url, for consistency.What issues does this PR fix or reference?
My mistake