This repository has been archived by the owner on Jan 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Code is ready, there is still a test file to fix left. I'm working on fixing it ATM |
davidfestal
approved these changes
May 3, 2019
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 61.43% 62.38% +0.95%
==========================================
Files 8 6 -2
Lines 809 553 -256
==========================================
- Hits 497 345 -152
+ Misses 264 182 -82
+ Partials 48 26 -22
Continue to review full report at Codecov.
|
amisevsk
approved these changes
May 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a few comments.
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
This was referenced May 10, 2019
metlos
pushed a commit
to metlos/che-plugin-broker
that referenced
this pull request
Jun 17, 2019
Copy plugins into 'v2/publisher' folders. Rename field name to displayName. Rename field id to name. Remove /meta.yaml from plugin links in index. Add deprecate section to old plugins. Rework scripts. Add migrate section to registry index. Add old notation plugins to v2 not to break exisiting workspaces. Adapt Readme.md. Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
metlos
pushed a commit
to metlos/che-plugin-broker
that referenced
this pull request
Jun 17, 2019
…aming convention Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
metlos
pushed a commit
to metlos/che-plugin-broker
that referenced
this pull request
Jun 17, 2019
…ming convention changes Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
metlos
pushed a commit
to metlos/che-plugin-broker
that referenced
this pull request
Jun 17, 2019
…build status icon to the README.md Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR reworks plugin broker to process meta.yaml with new structure.
Complete change of components needed to create this PR is described here eclipse-che/che#12908 (comment)
Plugins with new meta are placed in v3 folder of Che plugin registry https://github.com/eclipse/che-plugin-registry/tree/master/v3/plugins
What is changed in details:
spec
field of meta.yamlapiVersion
field. This PR requires meta.yaml to containapiVersion: v2
since current version of meta yaml is consideredv1
. This field will allow us to implement backward compatibility for future changes of meta.yaml modelurl
,extension
,extensions
,attributes
in meta.yaml is no longer supportedspec.extensions
field, which is array..theia
andvsix
archives in it and they are properly processed. This makes both types of extensions effectively the same.Che plugin
,Che editor
is no longer supported.editorCommands
in che-plugin.yaml renamed incommands
in meta.yamlChe editor
/Che plugin
tar archives is no longer supportededitors
field from che-plugin.yaml is no longer supportedChe plugin broker
is removed since it is no longer needed.Current limitations:
Examples of metas (more details at eclipse-che/che#12908 (comment)):
containers
field. The same content can be used as a plugin of typeTheia plugin
if type is replaced accordingly.What issues does this PR fix or reference?
Related to eclipse-che/che#12908