Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to nodejs 16 #1087

Merged
merged 1 commit into from
Nov 19, 2021
Merged

chore: switch to nodejs 16 #1087

merged 1 commit into from
Nov 19, 2021

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Nov 19, 2021

What does this PR do?

Use nodejs 16 during the builds

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Fixes eclipse-che/che#20795

How to test this PR?

PR check jobs should handle it

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Change-Id: I0d7b2cd14a395b052e3e21ff2219d558e808eabd
Signed-off-by: Florent Benoit fbenoit@redhat.com

Change-Id: I0d7b2cd14a395b052e3e21ff2219d558e808eabd
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #1087 (2c0c37f) into main (a95fbe7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1087   +/-   ##
=======================================
  Coverage   93.71%   93.71%           
=======================================
  Files          47       47           
  Lines        1400     1400           
  Branches      214      214           
=======================================
  Hits         1312     1312           
  Misses         88       88           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a95fbe7...2c0c37f. Read the comment docs.

@openshift-ci
Copy link

openshift-ci bot commented Nov 19, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: benoitf, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Nov 19, 2021
@benoitf
Copy link
Contributor Author

benoitf commented Nov 19, 2021

all tests are green, merging

@benoitf benoitf merged commit 1d4d8a7 into eclipse-che:main Nov 19, 2021
@che-bot che-bot added this to the 7.40 milestone Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch plug-in registry to nodejs 16 as it's the new nodejs LTS
3 participants