Add Apache Camel VS Code Extension (#109)

[apupier]

Signed-off-by: Aurélien Pupier apupier@redhat.com

create Pull request to check if tests are passing.

How and where to create automated test checking that the plugin is working correctly in Che?

What does this PR do?

this PR is adding Language Support for Camel to the list of extension

[apupier]

failure due to only svg are supported as icon:

!!!   Wrong icon type found in 'camel-tooling.vscode-apache-camel/0.0.14':
!!!   'https://github.com/camel-tooling/camel-lsp-client-vscode/raw/0.0.14/icons/icon128.png' Make sure it is pointing to .svg image.

[apupier]

I guess this PR will require to use a Github hosted vsix too.
Anything else which has prevented it to be merged?

[ibuziuk]

the rest looks good

[apupier]

using the direct link vsix to github is not working.
The installation seems to go fine. There is even the extension listed in plugins view but it is like the extension is not activated. There is no completion or hover. There is no output channel for the Language server created.

[apupier]

the Theia-ide log https://pastebin.com/T3X5zJvV

contains information like it is able to deploy the Camel Tooling Extension:

root INFO Resolved "camel-tooling.vscode-apache-camel.0.0.14.cameltooling_vscodeapachecamel" to a VS Code extension "vscode-apache-camel@0.0.14" with engines: { vscode: '^1.25.1' }
root INFO Deploying backend plugin "@eclipse-che/ports-plugin@0.0.1" from "/tmp/theia-unpacked/eclipse_che_ports_plugin.theia/lib/ports-plugin.js"
root INFO Deploying backend plugin "@eclipse-che/theia-containers-plugin@0.0.2" from "/tmp/theia-unpacked/eclipse_che_theia_containers_plugin.theia/lib/containers-plugin.js"
root INFO Deploying backend plugin "@eclipse-che/theia-factory-plugin@0.0.1" from "/tmp/theia-unpacked/eclipse_che_theia_factory_plugin.theia/lib/factory-plugin.js"
root INFO Deploying backend plugin "@eclipse-che/welcome-plugin@0.0.1" from "/tmp/theia-unpacked/eclipse_che_welcome_plugin.theia/lib/welcome-plugin.js"
root INFO Deploying backend plugin "task-plugin@0.0.1" from "/tmp/theia-unpacked/task_plugin.theia/lib/task-plugin-backend.js"
root INFO Deploying backend plugin "@theia/yeoman-plugin@0.0.1-1539189859" from "/tmp/theia-unpacked/theia_yeoman_plugin.theia/lib/theia-yeoman-plugin-backend-plugin.js"
root INFO Deploying backend plugin "vscode-apache-camel@0.0.14" from "/plugins/camel-tooling.vscode-apache-camel.0.0.14.cameltooling_vscodeapachecamel/extension/out/extension"

What is strange is that it is not part of the "initializing" log

root INFO [hosted-plugin: 45] PLUGIN_HOST(45): PluginManagerExtImpl/init()
root INFO [hosted-plugin: 45] PLUGIN_HOST(45): initializing(/home/theia/node_modules/@theia/plugin-ext/lib/hosted/node/scanners/backend-init-theia.js)
root INFO [hosted-plugin: 45] PLUGIN_HOST(45): initializing(/home/theia/node_modules/@theia/plugin-ext/lib/hosted/node/scanners/backend-init-theia.js)
root INFO [hosted-plugin: 45] PLUGIN_HOST(45): initializing(/home/theia/node_modules/@theia/plugin-ext/lib/hosted/node/scanners/backend-init-theia.js)
root INFO [hosted-plugin: 45] PLUGIN_HOST(45): initializing(/home/theia/node_modules/@theia/plugin-ext/lib/hosted/node/scanners/backend-init-theia.js)
root INFO [hosted-plugin: 45] PLUGIN_HOST(45): initializing(/home/theia/node_modules/@theia/plugin-ext/lib/hosted/node/scanners/backend-init-theia.js)
root INFO [hosted-plugin: 45] PLUGIN_HOST(45): initializing(/home/theia/node_modules/@theia/plugin-ext/lib/hosted/node/scanners/backend-init-theia.js)
root INFO [hosted-plugin: 45] PLUGIN_HOST(45): PluginManagerExtImpl/loadPlugin(/tmp/theia-unpacked/eclipse_che_ports_plugin.theia/lib/ports-plugin.js)
root INFO [hosted-plugin: 45] PLUGIN_HOST(45): PluginManagerExtImpl/loadPlugin(/tmp/theia-unpacked/eclipse_che_theia_containers_plugin.theia/lib/containers-plugin.js)
root INFO [hosted-plugin: 45] PLUGIN_HOST(45): PluginManagerExtImpl/loadPlugin(/tmp/theia-unpacked/eclipse_che_theia_factory_plugin.theia/lib/factory-plugin.js)
root INFO [hosted-plugin: 45] PLUGIN_HOST(45): PluginManagerExtImpl/loadPlugin(/tmp/theia-unpacked/eclipse_che_welcome_plugin.theia/lib/welcome-plugin.js)
root INFO [hosted-plugin: 45] PLUGIN_HOST(45): PluginManagerExtImpl/loadPlugin(/tmp/theia-unpacked/task_plugin.theia/lib/task-plugin-backend.js)
root INFO [hosted-plugin: 45] PLUGIN_HOST(45): PluginManagerExtImpl/loadPlugin(/tmp/theia-unpacked/theia_yeoman_plugin.theia/lib/theia-yeoman-plugin-backend-plugin.js)

[ibuziuk]

@apupier are you sure the binaries are the same? I'm not aware of anything url specific on plugin broker processing side

[apupier]

I used the vsix from the VSCode marketplace.
I double-checked that it is the correct vsix that i uploaded.
I redownloaded the vsix from github and installed it in a local VS Code instance and it is working fine

[apupier]

this line is quite strange:

root INFO Deploying backend plugin "vscode-apache-camel@0.0.14" from "/plugins/camel-tooling.vscode-apache-camel.0.0.14.cameltooling_vscodeapachecamel/extension/out/extension"

I would expect to have the extension.js like for other plugins.

I checked that in filesystem, there is only a file named extension.js at this place

[benoitf]

this line is quite strange:
root INFO Deploying backend plugin "vscode-apache-camel@0.0.14" from "/plugins/camel-tooling.vscode-apache-camel.0.0.14.cameltooling_vscodeapachecamel/extension/out/extension"

I would expect to have the extension.js like for other plugins.

vsix extensions package files in a subfolder extension so when unpacking files there are extra files but at the end it load the correct entry-point

[apupier]

I launched a third time and now the extension is working even with the github vsix url.
I notice no differences in the log compared to when it wasn't.

[garagatyi]

Please note that I added CircleCI and Eclipse sign off check to required checks for PRs.
Since this PR was created before CircleCI was configured in the repository you have to commit something to this PR to initiate CircleCI build that is required to proceed with merging the PR.
Sorry for the inconvenience.

[apupier]

I noticed that several other more recent PR have been merged.
Is something preventing merge of this PR?

[ibuziuk]

@apupier looks like you now also need to add the plugin to the https://github.com/eclipse/che-plugin-registry/tree/master/v2/plugins to have it available for selection once all the changes related to #55 are applied. But this should not block merging the PR @garagatyi wdyt?

[apupier]

I will prepare a commit with the modification for the v2.
Let me know if I add it to this branch or if it is better to create another PR.

[apupier]

I prepared another branch with v2 registry too https://github.com/apupier/che-plugin-registry/tree/109-addforregistryv1andV2 let me know how you prefer to proceed.

[garagatyi]

@apupier @ibuziuk I'm OK with either variant

[apupier]

added on top of this PR then.

Shellcheck is failing due to not related change to this PR. Mentioned to ignore it in this other PR comment #124 (comment)

[ibuziuk]

@apupier merged but you will need to add it in v3 also now due to - Merge meta.yaml and plugin yaml change - #135

[bfitzpat]

@apupier merged but you will need to add it in v3 also now due to - Merge meta.yaml and plugin yaml change - #135

Will take a look