Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set 7.0.0-next version of Che Theia image #183

Merged
merged 3 commits into from
Jul 17, 2019
Merged

Conversation

vparfonov
Copy link
Contributor

@vparfonov vparfonov commented Jul 15, 2019

Signed-off-by: Vitalii Parfonov vparfono@redhat.com

What does this PR do?

According to the eclipse-che/che-theia#347 need to use new Che Theia image

Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@vparfonov vparfonov marked this pull request as ready for review July 15, 2019 13:48
@vparfonov vparfonov changed the title Commit set SNAPSHOT version Set 7.0.0-rc-4.0-SNAPSHOT version of Che Theia image Jul 15, 2019
@benoitf
Copy link
Contributor

benoitf commented Jul 16, 2019

should it be instead 7.0.0-RC4-SNAPSHOT something like 7.0.0-nightly or 7.0.0-next ?
AFAIK images have never used the tag SNAPSHOT but nightly/latest/next

@benoitf
Copy link
Contributor

benoitf commented Jul 16, 2019

also it's unclear how release are made from che-theia branch, I didn't see update on eclipse-che/che#13782

with SNAPSHOT name I don't know if it is on each commit, every night, etc

@vparfonov
Copy link
Contributor Author

should it be instead 7.0.0-RC4-SNAPSHOT something like 7.0.0-nightly or 7.0.0-next ?
AFAIK images have never used the tag SNAPSHOT but nightly/latest/next

see here https://github.com/eclipse/che-theia/pull/347/files#diff-0f90e09c9296ab5840fb280db0cad7c6R17 please

@benoitf
Copy link
Contributor

benoitf commented Jul 16, 2019

yes I see where it was but it didn't ring the bell when I saw it.

Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@vparfonov vparfonov changed the title Set 7.0.0-rc-4.0-SNAPSHOT version of Che Theia image Set 7.0.0-next version of Che Theia image Jul 16, 2019
Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants