Update plugin meta yaml structure definition. #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
requested review from
l0rd,
rhopp,
skabashnyuk and
vparfonov
as code owners
sleshchenko
approved these changes
Sep 20, 2019
|
@AndrienkoAleksandr you should update the related che docs section as well. |
l0rd
reviewed
Sep 23, 2019
README.md
Outdated
| @@ -100,12 +100,44 @@ spec: # spec (used to be che-plugin.yaml) | |||
| env: # list of env vars to set in sidecar | |||
| - name: | |||
| value: | |||
| command: # optinal; definition of root process command inside container | |||
amisevsk
reviewed
Sep 24, 2019
README.md
Outdated
| volumes: # volumes required by plugin | ||
| - mountPath: | ||
| name: | ||
| persistVolume: # boolean; if true volume will be persisted, otherwise volume will be ephemeral; default value is true |
There was a problem hiding this comment.
Following the discussion here, I would go with a more k8s-like name here with a default value of false. I suggested emptyDir but ephemeral also works.
amisevsk
approved these changes
Sep 26, 2019
AndrienkoAleksandr
deleted the
updatePluginMetaYamlStructureDefinition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update plugin meta yaml structure definition: defined commands and arguments for plugin container, defined initContainers field, defined persistVolume field.
Referenced issue:
eclipse-che/che#13387
Depends on eclipse-che/che-plugin-broker#74 and eclipse-che/che#14539