Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubernetes Che Plugin based on the VS Code Kubernetes extension 1.0.4 #256

Merged
merged 2 commits into from
Oct 21, 2019

Conversation

azatsarynnyy
Copy link
Member

@azatsarynnyy azatsarynnyy commented Oct 16, 2019

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

What does this PR do?

Adds Kubernetes Tooling Che Plugin based on the latest VS Code Kubernetes extension 1.0.4 that includes support of Buildah tool.

Depends on eclipse-che/che-theia#493

What issues does this PR fix or reference?

eclipse-che/che#13316

….0.4

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you also update latest to be version 1.0.4? Not sure what the standard policy is, but seems strange to have 1.0.0 in /latest/ and there then be a /1.0.4/ too.

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@azatsarynnyy
Copy link
Member Author

Thanks @nickboldt for spotting that! I've updated the PR.

Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@nickboldt
Copy link
Contributor

Show of hands -- should we include this in CRW plugin reg instead of v 1.0.0?

@azatsarynnyy
Copy link
Member Author

should we include this in CRW plugin reg instead of v 1.0.0

It doesn't add new functionality compared with the previous version (1.0.0) until eclipse-che/che#13702 is fixed.

@azatsarynnyy azatsarynnyy merged commit 79f043d into master Oct 21, 2019
@azatsarynnyy azatsarynnyy deleted the kube-1.0.4 branch October 21, 2019 09:51
ibuziuk pushed a commit to ibuziuk/che-plugin-registry that referenced this pull request Oct 28, 2019
….0.4 (eclipse-che#256)

* Add Kubernetes Che Plugin based on the VS Code Kubernetes extension 1.0.4

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

* Point k8s plugin latest version to 1.0.4

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
ibuziuk pushed a commit that referenced this pull request Oct 28, 2019
….0.4 (#256)

* Add Kubernetes Che Plugin based on the VS Code Kubernetes extension 1.0.4

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

* Point k8s plugin latest version to 1.0.4

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants