#14927 remove node-debug (support for Node <... #264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de 12 is Current, and Node 8 is old but still in maintenance. Do we REALLY need Node 4 & 6 support?? Signed-off-by: nickboldt <nboldt@redhat.com>
nickboldt
requested review from
amisevsk,
l0rd,
rhopp,
skabashnyuk and
vparfonov
as code owners
This was referenced Oct 23, 2019
|
With Stevan's approval in eclipse-che/che#14927 I'll update this PR and we can finally dump Node < 8 support. :) |
amisevsk
reviewed
Nov 26, 2019
There was a problem hiding this comment.
I'm generally in favor of not working to support ancient node versions, but this does pose a question for how plugins are fully deprecated from the registry. A user moving from 7.4.0 to e.g. 7.5.0 (were this to be merged) would be left with a non-starting workspace with no indication of what the issue is and how to resolve it.
For this plugin it's probably not an actual issue, but in general we need some way for passing this information to a user. In the mean time it may be better to just live with out mistake until that is in place.
|
replaced by #302 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eclipse-che/che#14927 remove node-debug (support for Node < 8) as Node 10 is LTS, Node 12 is Current, and Node 8 is old but still in maintenance. Do we REALLY need Node 4 & 6 support??
Signed-off-by: nickboldt nboldt@redhat.com