-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#14573 do not reference MS VSCode... #309
Conversation
See eclipse-che/che/issues/15327 -- should we just REMOVE 2.7.6 in favour of 2.7.7, or add 2.7.7 and leave 2.7.6 hanging around even though it's in violation of eclipse-che/che/issues/14573 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great news.
I think 2.7.6 should remain for the time being, give eclipse-che/che#15327 (comment). We should keep it for a few sprints as removing it now would mean that when users rollout to 7.6.0, any workspaces that explicitly used 2.7.6
would fail to start.
We can also look into using the deprecate
and migrateTo
options for 2.7.6
, e.g. as we do for the old camel plugin
Then keep version 2.7.6 for some time and add version 2.7.7 now as the new default? |
…2.7.7 which is in GH Signed-off-by: nickboldt <nboldt@redhat.com>
…de-asciidoctor/latest Signed-off-by: nickboldt <nboldt@redhat.com>
0b67c7c
to
f75812b
Compare
Updated to keep 2.7.6 (but deprecate it). Note that the docs for the deprecation give non-example of |
Change-Id: Ibbc29dfda5fa56e1555dfb675e580c7549aab852 Signed-off-by: nickboldt <nboldt@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm always 👍 on incremental documentation improvements!
#14573 do not reference MS VSCode marketplace directly; instead use v2.7.7 which is in GH
Signed-off-by: nickboldt nboldt@redhat.com