Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#14573 do not reference MS VSCode... #309

Merged
merged 3 commits into from
Dec 3, 2019

Conversation

nickboldt
Copy link
Contributor

#14573 do not reference MS VSCode marketplace directly; instead use v2.7.7 which is in GH

Signed-off-by: nickboldt nboldt@redhat.com

@nickboldt
Copy link
Contributor Author

nickboldt commented Dec 3, 2019

See eclipse-che/che/issues/15327 -- should we just REMOVE 2.7.6 in favour of 2.7.7, or add 2.7.7 and leave 2.7.6 hanging around even though it's in violation of eclipse-che/che/issues/14573 ?

Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great news.

I think 2.7.6 should remain for the time being, give eclipse-che/che#15327 (comment). We should keep it for a few sprints as removing it now would mean that when users rollout to 7.6.0, any workspaces that explicitly used 2.7.6 would fail to start.

We can also look into using the deprecate and migrateTo options for 2.7.6, e.g. as we do for the old camel plugin

@themr0c
Copy link

themr0c commented Dec 3, 2019

Then keep version 2.7.6 for some time and add version 2.7.7 now as the new default?

…2.7.7 which is in GH

Signed-off-by: nickboldt <nboldt@redhat.com>
…de-asciidoctor/latest

Signed-off-by: nickboldt <nboldt@redhat.com>
@nickboldt
Copy link
Contributor Author

nickboldt commented Dec 3, 2019

Updated to keep 2.7.6 (but deprecate it).

Note that the docs for the deprecation give non-example of migrateTo: another_publisher/another_plugin_id:1.0.0 but an actual working example shows we use migrateTo: redhat/vscode-apache-camel/latest -- not using :tag syntax but rather /version syntax

Change-Id: Ibbc29dfda5fa56e1555dfb675e580c7549aab852
Signed-off-by: nickboldt <nboldt@redhat.com>
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm always 👍 on incremental documentation improvements!

@nickboldt nickboldt merged commit 1e59dfa into eclipse-che:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants