Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

che #15506 Adding release instructions for che-plugin-registry #360

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Jan 28, 2020

What does this PR do?

Adding release instructions for che-plugin-registry (major/minor/service/bug-fix)

Issue - eclipse-che/che#15506

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very useful to have the process written out.


The last things that need to be done:
- the `7.8.0` tag creation from the `7.8.x` branch
- providing a PR with adding the latest `7.8.0` versions of the `che-theia` and `che-machine-exec` to master.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness, I'd add that the snapshot version number in the master branch needs to be bumped as well, in the off chance it ends up forgotten.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd make a few small grammatical tweaks (your verb tenses switch from "create" to "adding") but otherwise content is good.

@nickboldt nickboldt merged commit 8cbe890 into eclipse-che:master Jan 28, 2020
@nickboldt
Copy link
Contributor

These steps will be scripted soon and I'll update the .md at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants