Add CPU limit/request and RAM request into meta.yaml schema #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshaposhnik
requested review from
benoitf,
vinokurig and
vitaliy-guliy
as code owners
amisevsk
reviewed
Feb 18, 2020
sleshchenko
reviewed
Feb 19, 2020
Co-Authored-By: Sergii Leshchenko <sleshche@redhat.com>
Co-Authored-By: Sergii Leshchenko <sleshche@redhat.com>
sleshchenko
approved these changes
Mar 2, 2020
build/scripts/meta.yaml.schema
Outdated
| }, | ||
| "cpuLimit": { | ||
| "type": "string", | ||
| "pattern": "^[0-9]+(\\.[0-9]+)?$|^[1-9][0-9]*m$" |
There was a problem hiding this comment.
Suggested change
| "pattern": "^[0-9]+(\\.[0-9]+)?$|^[1-9][0-9]*m$" | |
| "pattern": "^[1-9]+[0-9]*(\\.[0-9]+)?$|^[1-9][0-9]*m$" |
consider to prevent numbers like 000003
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds CPU limit/request and RAM request into meta.yaml schema
Ticket: eclipse-che/che#13709