Adding dirigible-che-editor-plugin #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: delchev <delchevn@gmail.com>
benoitf
approved these changes
Nov 2, 2018
|
Really cool ! thanks @delchev |
|
@benoitf who is going to merge this one? |
|
I'm waiting other approvals then we can merge it |
|
btw it seems CI job has failed. Need to investigate |
skabashnyuk
reviewed
Nov 3, 2018
| @@ -0,0 +1,8 @@ | |||
| id: dirigible-che-editor-plugin | |||
There was a problem hiding this comment.
Suggested change
| id: dirigible-che-editor-plugin | |
| id: org.eclipse.che.editor.dirigible |
There was a problem hiding this comment.
@skabashnyuk we don't have a naming convention yet. I wouldn't go with the Java packages naming anyway (too verbose). I have created #55 to discuss that.
There was a problem hiding this comment.
We have convention that path should be plugins/{id}/{version}/meta.yaml
| title: Eclipse Dirigible for Eclipse Che | ||
| description: Eclipse Dirigible as App Development Platform for Eclipse Che | ||
| icon: https://www.dirigible.io/img/logo/dirigible-logo.png | ||
| url: https://github.com/dirigiblelabs/dirigible-che-editor-plugin/releases/download/1.0.0/dirigible-che-editor-plugin.tar.gz |
There was a problem hiding this comment.
Suggested change
| url: https://github.com/dirigiblelabs/dirigible-che-editor-plugin/releases/download/1.0.0/dirigible-che-editor-plugin.tar.gz | |
| url: https://github.com/dirigiblelabs/dirigible-che-editor-plugin/releases/download/1.0.0/dirigible-che-editor-plugin.tar.gz | |
l0rd
approved these changes
Nov 5, 2018
Signed-off-by: delchev <delchevn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ins/org.eclipse.che.editor.dirigible/1.0.0/meta.yaml
What does this PR do?
Adding Eclipse Dirigible Che Plugin