feat(plugins): Use meta.yaml content generated by script

[benoitf]

What does this PR do?

• Use icons specified inside the vsix files
• Also update field information based on data from the linked vsix

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#17029

How to test this PR?

build the registry and browse plug-in registy

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Change-Id: I6ee177116b327d479ad3ea8808ebbfb3251300e6
Signed-off-by: Florent Benoit fbenoit@redhat.com

[ericwill]

Are we in the clear from a licensing perspective?

[benoitf]

I would say yes as these icons are provided to be exposed by a registry/marketplace/etc.
These icons are already provided by open-vsx as well

[ericwill]

I would say yes as these icons are provided to be exposed by a registry/marketplace/etc.
These icons are already provided by open-vsx as well

OK, I agree

[vitaliy-guliy]

Why is it better to have the icons inside our repository?
I'm just wonder how it's related to generating of meta.yamls

It there a script used to fetch those icons from .vsix files?

In Che we use docker image with plugin registry. The build script could fetch all those icons from .vsix and place them named {publisher}.{id}.png to /images directory inside docker image. And yes, all the meta.yamls for vs code extensions should be preprocessed with changing the icon path.
This gives us not to store the icons in this repository but have them inside the container.
WDYT?

[benoitf]

@vitaliy-guliy: all that you're saying is correct
here it's like the last intermediate step before removing all meta.yaml and images and make it only available in the final image (build time fetch)

The script is there #721 (it extracts vsix/icons automatically and create meta.yaml)

[benoitf]

closing as it was to check diff between what is generated and what is available

PR to follow is #721