fail overall build with exit 1 if maven... #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
nickboldt
force-pushed
the
fail-for-maven-build-failures
branch
from
916be53 to
fdb3c2e
Compare
Change-Id: I83f5233188285764b33bf58cb868ba6c2ec2c4d6 Signed-off-by: nickboldt <nboldt@redhat.com> remove some empty lines Change-Id: I86c0ccca5bd3072afa24daec7dab9969447234fe Signed-off-by: nickboldt <nboldt@redhat.com> don't fail for any [ERROR] lines, as tests sometimes pass (???) with those; instead check for BUILD FAILURE lines; generalize into helper method Change-Id: Iea0e15f9499325bcdf170cac40dea4ac5f1e4ff5 Signed-off-by: nickboldt <nboldt@redhat.com> trap actual exit code, not the result of toggling 'set -e' back on Change-Id: Ia1e4c922a0a8ed6cd0060de99c7ee8a1d2ab2230 Signed-off-by: nickboldt <nboldt@redhat.com>
nickboldt
force-pushed
the
fail-for-maven-build-failures
branch
from
fdb3c2e to
659e229
Compare
mkuznyetsov
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fail overall build with exit 1 if maven builds fail
Change-Id: I83f5233188285764b33bf58cb868ba6c2ec2c4d6
Signed-off-by: nickboldt nboldt@redhat.com
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#18792
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.