fix: Token validity check #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metlos
requested review from
amisevsk,
mshaposhnik,
nickboldt,
skabashnyuk and
sleshchenko
as code owners
…f 500 with OpenShift OAuth the same as it is already done with Keycloak. Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
metlos
force-pushed
the
token-validity-check
branch
from
bafa1d9 to
11f75dd
Compare
|
[crw-ci-test --rebuild] |
|
✅ E2E Happy path tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
skabashnyuk
approved these changes
Sep 24, 2021
sparkoo
reviewed
Sep 24, 2021
...he/multiuser/api/authentication/commons/filter/MultiUserEnvironmentInitializationFilter.java
Outdated
Show resolved
Hide resolved
...e/workspace/infrastructure/openshift/multiuser/oauth/OpenshiftTokenInitializationFilter.java
Outdated
Show resolved
Hide resolved
...e/workspace/infrastructure/openshift/multiuser/oauth/OpenshiftTokenInitializationFilter.java
Outdated
Show resolved
Hide resolved
…thod getCurrentUser Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
|
❌ E2E Happy path tests failed ❗ See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
|
✅ E2E Happy path tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
sparkoo
approved these changes
Sep 27, 2021
...e/workspace/infrastructure/openshift/multiuser/oauth/OpenshiftTokenInitializationFilter.java
Outdated
Show resolved
Hide resolved
mshaposhnik
reviewed
Sep 27, 2021
...he/multiuser/api/authentication/commons/filter/MultiUserEnvironmentInitializationFilter.java
Outdated
Show resolved
Hide resolved
mshaposhnik
reviewed
Sep 27, 2021
...he/multiuser/api/authentication/commons/filter/MultiUserEnvironmentInitializationFilter.java
Show resolved
Hide resolved
It should not return null under normal operation, but I'm not sure about the abnormal operation :) Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
raw token in any implementation, so let's remove it from the method sig. Signed-off-by: Lukas Krejci <lkrejci@redhat.com>
|
✅ E2E Happy path tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
mshaposhnik
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This changes the HTTP status code from 500 to 401 when we encounter an invalid token in an authenticated request while using the native user mode on OpenShift.
The implemented fix slightly refactors the way the user information is processed from the token such that it is processed just once.
Note that this is only a partial fix for the issue eclipse-che/che#20304. We also need changes in the che-gateway (deployed by the che-operator) for this to be bullet-proof and caught as early as possible.
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#20304
How to test this PR?
Follow the instructions in the issue eclipse-che/che#20304. The HTTP status code of the response should now be 401.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.