Fixup for oauth2 usernames #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
|
❌ E2E Happy path tests failed ❗ See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
mshaposhnik
requested review from
amisevsk,
metlos,
nickboldt,
skabashnyuk and
sleshchenko
as code owners
|
❌ E2E Happy path tests failed ❗ See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
mshaposhnik
requested review from
sparkoo and
xbaran4
and removed request for
nickboldt,
sleshchenko and
amisevsk
|
✅ E2E Happy path tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
skabashnyuk
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Max Shaposhnik mshaposh@redhat.com
What does this PR do?
When authentication is done using OAuth2 tokens, git credential must have form
http://oauth2:<password>@server.cominstead ofhttp://<username>:<password>@server.comScreenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#20790
How to test this PR?
Try to perform clone from private GitLab repository. Before fix it will fail. Afret fix, wokring OK.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.