Fix behavior for unexisting files for public repositories #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
benoitf
approved these changes
Jan 17, 2022
| String clientId = Files.readString(Path.of(clientIdPath)); | ||
| String clientSecret = Files.readString(Path.of(clientSecretPath)); | ||
| final String clientId = Files.readString(Path.of(clientIdPath)).trim(); | ||
| final String clientSecret = Files.readString(Path.of(clientSecretPath)).trim(); |
There was a problem hiding this comment.
thanks for this enhancement !
|
|
||
| @Override | ||
| protected boolean isPublicRepository(GithubUrl remoteFactoryUrl) { | ||
| try { |
There was a problem hiding this comment.
it works but this method should be added to GithubApiClient directly no ?
https://github.com/eclipse-che/che-server/blob/21edcc0cdac7add1b6e705c8fe0118b2e150d0da/wsmaster/che-core-api-factory-github/src/main/java/org/eclipse/che/api/factory/server/github/GithubApiClient.java
There was a problem hiding this comment.
Now it's just a small helper, which if moved to ApiClient should be expanded to have POJO for response, support authentication etc. so i stick to simpler variant.
skabashnyuk
approved these changes
Jan 17, 2022
skabashnyuk
pushed a commit
to skabashnyuk/che-server
that referenced
this pull request
Feb 2, 2022
…e#243) Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
9 tasks
skabashnyuk
added a commit
to skabashnyuk/che-server
that referenced
this pull request
Feb 2, 2022
…ipse-che#243) Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
skabashnyuk
added a commit
to skabashnyuk/che-server
that referenced
this pull request
Feb 3, 2022
…es (eclipse-che#243) Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
skabashnyuk
added a commit
that referenced
this pull request
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Max Shaposhnik mshaposh@redhat.com
What does this PR do?
Added check for unexisting files if the're hosted in the public repo. In this case a
404response returned instead of OAuth login request.Fixed OAuth credentials reading from file
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#20994
eclipse-che/che#21014
How to test this PR?
Setup Che, configure OAuth, create factory from public repo with devfile v2.0 but some missing files like
/.che/che-theia-plugins.yaml. 401 was returned on this file previously, and factory failed. After fix 404 is returned, andfactory is launched successfully.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.