-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Apply Bitbucket SAAS Oauth flow #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
vinokurig
requested review from
skabashnyuk,
nickboldt,
ibuziuk,
themr0c,
MichalMaler and
sparkoo
as code owners
July 15, 2022 14:44
svor
approved these changes
Jul 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties
Outdated
Show resolved
Hide resolved
...auth-bitbucket/src/main/java/org/eclipse/che/security/oauth/BitbucketOAuthAuthenticator.java
Outdated
Show resolved
Hide resolved
...bitbucket/src/main/java/org/eclipse/che/api/factory/server/bitbucket/BitbucketApiClient.java
Outdated
Show resolved
Hide resolved
...in/java/org/eclipse/che/api/factory/server/bitbucket/BitbucketFactoryParametersResolver.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/eclipse/che/api/factory/server/bitbucket/BitbucketSourceStorageBuilder.java
Outdated
Show resolved
Hide resolved
Thank you for the catch, I will clarify this in the documentation part. |
tolusha
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Igor Vinokur ivinokur@redhat.com
What does this PR do?
Since we support only Bitbucket Server Oauth flow, added a support for the SAAS version
depends on eclipse-che/che-operator#1445
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#21517
How to test this PR?
chectl server:deploy -p=openshift --che-operator-image=quay.io/ivinokur/che-operator:next -i=quay.io/ivinokur/che-server:next
Set
<eclipse-che endpoint>/api/oauth/callback
as aCallback URL
Set all
Account
andRepository
permissionsPR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.