-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support configuring the GitHub OAuth endpoint #350
Conversation
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
...e-api-auth-github/src/main/java/org/eclipse/che/security/oauth/GitHubOAuthAuthenticator.java
Outdated
Show resolved
Hide resolved
assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties
Outdated
Show resolved
Hide resolved
…/che/che.properties Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
@l0rd @nickboldt Do we need to cherry-pick it to a release branch? |
@vinokurig if that's not too complicated it would be ideal to cherry pick that to 7.52.x branch |
@vinokurig I have added this in the epic for the release of OpenShift Dev Spaces 3.2. Please let me know if you think that it won't be possible to backport it to 7.52.x so that we revert that in time. cc @nickboldt @dmytro-ndp |
Currently the GitHub OAuth provider is hardcoded to https://github.com endpoint. In order to support Github Enterprise Server, the endpoint of the GitHub OAuth provider is configurable by the oauth secret.
@l0rd Successfully cherry-picked to 7.52.x |
@nickboldt Can you please suggest when we might see this commit in Dev Spaces 3.2 or 3.3? |
cherrypicked 7 days ago so built and available from Quay https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags&tag=3.2 |
Signed-off-by: Igor Vinokur ivinokur@redhat.com
What does this PR do?
Currently the GitHub OAuth provider is hardcoded to
https://github.com
endpoint. In order to support Github Enterprise Server, the endpoint of the GitHub OAuth provider is configurable by the oauth secret.Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#21485
How to test this PR?
che-server
image built from the PR source:quay.io/ivinokur/che-server:next
.The secret refers to the GitHub Enterprise Server instace, launched in my local virtualbox environment, and exposed to
http://37.139.177.199
, see for more details.3. Ping me to start the GitHub instance :) or use your own application, but configure the endpoint in the secret.
4. Start a factory from
http://37.139.177.199/test/test.git
or your own repo.PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.