Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to default editor = che-incubator/che-code/latest #393

Closed
wants to merge 1 commit into from

Conversation

nickboldt
Copy link
Contributor

@nickboldt nickboldt commented Nov 28, 2022

What does this PR do?

chore: switch to default editor = che-incubator/che-code/latest (CRW-3099, CRW-3420, eclipse-che/che#20500)

Change-Id: Ib576241488e9ada5465dd45a9bc140cd6b4ed7e6
Signed-off-by: Nick Boldt nboldt@redhat.com

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-3099,
https://issues.redhat.com/browse/CRW-3420,
eclipse-che/che#20500

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

…3099, CRW-3420, eclipse-che/che#20500)

Change-Id: Ib576241488e9ada5465dd45a9bc140cd6b4ed7e6
Signed-off-by: Nick Boldt <nboldt@redhat.com>
@nickboldt nickboldt changed the title chore: switch to default editor =... chore: switch to default editor = che-incubator/che-code/latest Nov 28, 2022
Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think the PR is relevant
@nickboldt could you clarify how was it tested?

@nickboldt
Copy link
Contributor Author

how was it tested?

Other than the automated checks, it was not manually tested.

@themr0c
Copy link
Contributor

themr0c commented Jan 12, 2023

I don't know why @MichalMaler and @themr0c are marked as reviewers: you can safely remove us from the reviewer list.
If you need docs team reviewers, it should rather be: @rkratky, @max-cx, @deerskindoll and @osslate.

@nickboldt
Copy link
Contributor Author

@ibuziuk so should we merge this or wait until 7.62 / 3.6 when we're removing theia entirely...?

@nickboldt nickboldt requested a review from l0rd February 2, 2023 17:13
@nickboldt
Copy link
Contributor Author

nickboldt commented Feb 2, 2023

@themr0c:

I don't know why @MichalMaler and @themr0c are marked as reviewers: you can safely remove us from the reviewer list.
If you need docs team reviewers, it should rather be: @rkratky, @max-cx, @deerskindoll and @osslate.

See #434 - in which I'm removing and simplifying the CODEOWNERS to exclude people who shouldn't be there anymore.

You were in there previously because the che.properties file is pseudo-doc and directly affects the che docs + downstream docs too.

@nickboldt nickboldt requested a review from ibuziuk February 2, 2023 17:15
@l0rd
Copy link
Contributor

l0rd commented Feb 7, 2023

I am not sure what's your purpose @nickboldt but the default editor is specified here. These properties are not used anymore.

@ibuziuk
Copy link
Member

ibuziuk commented Mar 8, 2023

closing as irrelevant

@ibuziuk ibuziuk closed this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants