Add an ability to create and edit namespaced secrets by workspace user #44
Conversation
vinokurig
requested review from
amisevsk,
metlos,
nickboldt,
skabashnyuk and
sleshchenko
as code owners
…e user Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
There was a problem hiding this comment.
pay attention that it won't work for existing namespaces, only newly created due eclipse-che/che#19697
...lipse/che/workspace/infrastructure/kubernetes/namespace/AbstractWorkspaceServiceAccount.java
Show resolved
Hide resolved
|
✅ E2E Happy path tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
|
Do we need documentation for that? |
| SECRETS_ROLE_NAME, | ||
| Arrays.asList("secrets"), | ||
| singletonList(""), | ||
| Arrays.asList("list", "create", "delete"), |
There was a problem hiding this comment.
is there a way to test these roles?
There was a problem hiding this comment.
I've added a testcase but all tests in this module are ignored. Should I create an issue for that?
|
LGTM to me in general. Let's see that other folks are thinking about that. |
I don't think so because it doesn't affect user experience. We might add some for the related issue. |
|
✅ E2E Happy path tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Signed-off-by: Igor Vinokur ivinokur@redhat.com
What does this PR do?
To be able to create edit and delete namespaced secretes workspace user needs special permissions. This PR adds a kubernetes role for secrets, and binds it to a workspace user.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#19837
How to test this PR?
curl -X POST <kubernetes API url>/api/v1/namespaces/<namespace name>/secrets --header "Content-Type: application/json" -d '{ "apiVersion": "v1", "kind": "Secret", "metadata": { "name" : "new-secret" } }'PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.