Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide scm info in factory v2 #5

Merged
merged 3 commits into from
May 24, 2021
Merged

Conversation

mshaposhnik
Copy link
Contributor

@mshaposhnik mshaposhnik commented May 21, 2021

What does this PR do?

Provide SCM project details required for dashboard from Che-server in a separate field on the Factory.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#19816

How to test this PR?

  1. deploy test image mshaposh/che-server:nightly
  2. accept factory with devfile v2.
  3. make sure factory contains SCM details field

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@mshaposhnik mshaposhnik requested review from sparkoo and removed request for nickboldt May 21, 2021 09:30
@skabashnyuk skabashnyuk self-requested a review May 24, 2021 11:41
Copy link
Member

@sparkoo sparkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@skabashnyuk skabashnyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me
Знімок екрана 2021-05-24 о 15 08 53
Знімок екрана 2021-05-24 о 15 03 53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants