Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Workspace Roles and RoleBindings provision on each restart #52

Merged
merged 13 commits into from
Jul 21, 2021
Merged

fix: Workspace Roles and RoleBindings provision on each restart #52

merged 13 commits into from
Jul 21, 2021

Conversation

mshaposhnik
Copy link
Contributor

@mshaposhnik mshaposhnik commented Jul 14, 2021 •
edited
Loading

What does this PR do?

In case if Roles or RoleBindings were changed (updated/removed/added), existing workspace ServiceAccount doesn't apply such updates since we're create and provision it only once during with namespace creation. This PR makes SA roles/RB-s provision done on each restart.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@mshaposhnik mshaposhnik requested a review from metlos July 14, 2021 10:01
@che-bot
Copy link
Contributor

che-bot commented Jul 14, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@che-bot
Copy link
Contributor

che-bot commented Jul 15, 2021

❌ E2E Happy path tests failed ❗

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@mshaposhnik mshaposhnik changed the title Test changes fix: Workspace Roles and RoleBindings provision on each restart Jul 16, 2021
@che-bot
Copy link
Contributor

che-bot commented Jul 16, 2021

❌ E2E Happy path tests failed ❗

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@mshaposhnik mshaposhnik marked this pull request as ready for review July 16, 2021 21:01
@che-bot
Copy link
Contributor

che-bot commented Jul 17, 2021

❌ E2E Happy path tests failed ❗

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@skabashnyuk skabashnyuk requested review from sparkoo and xbaran4 July 19, 2021 05:46
@mshaposhnik
minor fixup
6d81851 
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
@mshaposhnik
Merge with main
b70e684
@che-bot
Copy link
Contributor

che-bot commented Jul 21, 2021

❌ E2E Happy path tests failed ❗

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@mshaposhnik
Fixup test
1114c99 
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
@mshaposhnik mshaposhnik merged commit 0860eda into eclipse-che:main Jul 21, 2021
@mshaposhnik mshaposhnik deleted the test_sa_update branch July 21, 2021 19:59
@che-bot che-bot added this to the 7.34 milestone Jul 21, 2021
@che-bot
Copy link
Contributor

che-bot commented Jul 21, 2021

❌ E2E Happy path tests failed ❗

See Details

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@metlos metlos Awaiting requested review from metlos

@amisevsk amisevsk Awaiting requested review from amisevsk

@sparkoo sparkoo Awaiting requested review from sparkoo

@xbaran4 xbaran4 Awaiting requested review from xbaran4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.34
Development

Successfully merging this pull request may close these issues.
3 participants
@mshaposhnik @che-bot @skabashnyuk