Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openjdk version from 11 to 17 #535

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Update openjdk version from 11 to 17 #535

merged 1 commit into from
Jul 25, 2023

Conversation

vinokurig
Copy link
Contributor

What does this PR do?

Update openjdk version from 11 to 17 in order to fix the che-server sturtup error

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#22384

How to test this PR?

Deploy che and go to the dashboard

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
@vinokurig
Copy link
Contributor Author

/retest

@tolusha
Copy link
Contributor

tolusha commented Jul 25, 2023

We have reference to JDK 11 here:
https://github.com/eclipse-che/che-server/blob/main/README.md#build-requirements

The main question, why does it stop working with JDK 11?

@vinokurig
Copy link
Contributor Author

vinokurig commented Jul 25, 2023

@tolusha

We have reference to JDK 11 here:
https://github.com/eclipse-che/che-server/blob/main/README.md#build-requirements

This is the Java version to build the project sources but the PR is about to update the Java in the che-server container

The main question, why does it stop working with JDK 11?

I assume that the java-11-openjdk package has been updated with some missing packages and caused the build breack

@openshift-ci
Copy link

openshift-ci bot commented Jul 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinokurig vinokurig merged commit 0067589 into main Jul 25, 2023
4 checks passed
@vinokurig vinokurig deleted the che-22384 branch July 25, 2023 08:04
ibuziuk pushed a commit to ibuziuk/che-server that referenced this pull request Aug 9, 2023
Update openjdk version from 11 to 17 in order to fix the che-server sturtup error
SDawley added a commit that referenced this pull request Aug 9, 2023
Update openjdk version from 11 to 17 (#535)
All tests passed, merging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Che-server image built by the PR GitHub action fails to start
3 participants