-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use login
instead of name
in the GitHub scopes/username request
#537
Conversation
Please, backport to 7.72.x for 3.8 once merged |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified with quay.io/eclipse/che-server:pr-537
Added personal access token (classic)
Verified workspace creation from private repository using both ssh and https.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk, ScrewTSW, tolusha, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…537) Change user.getName() to user.getLogin() in the GitHub getTokenScopes() API request, in order to fix a bug where NullPointer exception is appeared when a GitHub user request returns a user with null in the name field.
done |
Build 3.9 :: server_3.x/191: Console, Changes, Git Data |
Build 3.9 :: sync-to-downstream_3.x/3898: Console, Changes, Git Data |
Build 3.9 :: push-latest-container-to-quay_3.x/2842: Console, Changes, Git Data |
Build 3.9 :: get-sources-rhpkg-container-build_3.x/3754: server : 3.x :: Build 54462691 : quay.io/devspaces/server-rhel8:3.9-5 |
Build 3.9 :: server_3.x/191: Upstream sync done; /DS_CI/sync-to-downstream_3.x/3898 triggered |
Build 3.9 :: update-digests_3.x/3857: Console, Changes, Git Data |
Build 3.9 :: operator-bundle_3.x/1679: Console, Changes, Git Data |
Build 3.9 :: sync-to-downstream_3.x/3907: Console, Changes, Git Data |
Build 3.9 :: push-latest-container-to-quay_3.x/2853: Console, Changes, Git Data |
Build 3.9 :: copyIIBsToQuay/1615: Console, Changes, Git Data |
Build 3.9 :: sync-to-downstream_3.x/3907: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/3761 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.9 :: operator-bundle_3.x/1679: Upstream sync done; /DS_CI/sync-to-downstream_3.x/3907 triggered |
Build 3.9 :: update-digests_3.x/3857: Detected new images: rebuild operator-bundle |
Build 3.9 :: dsc_3.x/1105: Console, Changes, Git Data |
Build 3.9 :: server_3.x/192: Console, Changes, Git Data |
Build 3.9 :: sync-to-downstream_3.x/3989: Console, Changes, Git Data |
What does this PR do?
Change
user.getName()
touser.getLogin()
in the GitHubgetTokenScopes()
API request, in order to fix a bug whereNullPointer
exception is appeared when a GitHub user request returns a user withnull
in thename
field.Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#22413
How to test this PR?
Name
input and hitSave
personal-access-token-****
git-credentials-secret-****
devworkspace-merged-git-credentials
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.