-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect authorisation request opt-out on workspace start #576
Conversation
/retest |
3 similar comments
/retest |
/retest |
/retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code generally looks good to me, though I haven't been able to test the changes.
...org/eclipse/che/api/factory/server/scm/kubernetes/KubernetesAuthorisationRequestManager.java
Show resolved
Hide resolved
/retest |
/retest |
1 similar comment
/retest |
Verified according to steps in the |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, artaleks9, ibuziuk, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.10 :: server_3.x/257: Console, Changes, Git Data |
Build 3.10 :: sync-to-downstream_3.x/4928: Console, Changes, Git Data |
Build 3.10 :: push-latest-container-to-quay_3.x/3482: Console, Changes, Git Data |
Build 3.10 :: get-sources-rhpkg-container-build_3.x/4750: server : 3.x :: Build 56149135 : quay.io/devspaces/server-rhel8:3.10-18 |
Build 3.10 :: server_3.x/257: Upstream sync done; /DS_CI/sync-to-downstream_3.x/4928 triggered |
Build 3.10 :: update-digests_3.x/4589: Console, Changes, Git Data |
Build 3.10 :: update-digests_3.x/4589: No new images detected: nothing to do! |
What does this PR do?
If user rejects an scm provider authorisation request while creating or starting existed workspace store the name of the scm provider in the
workspace-preferences
config-map. The workspace create/start step must proceed without token fetch step. If user creates another workspace or starts existed workspace from an scm provider which name is stored in the config-map, do not ask the authorisation as it was already rejected once.Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#22499
How to test this PR?
quay.io/eclipse/che-server:pr-576
cancel
button.PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.