-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip refresh GitHub tokens, override refresh Azure DevOps token request #699
Conversation
/retest |
1 similar comment
/retest |
Verified on Eclipse Che with |
/retest |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: artaleks9, ibuziuk, tolusha, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.16 :: server_3.x/349: Console, Changes, Git Data |
Build 3.16 :: sync-to-downstream_3.x/7308: Console, Changes, Git Data |
Build 3.16 :: push-latest-container-to-quay_3.x/4784: Console, Changes, Git Data |
Build 3.16 :: get-sources-rhpkg-container-build_3.x/7288: server : 3.x :: Build 62892456 : quay.io/devspaces/server-rhel8:3.16-9 |
Build 3.16 :: server_3.x/349: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7308 triggered |
Build 3.16 :: update-digests_3.x/7137: Console, Changes, Git Data |
Build 3.16 :: update-digests_3.x/7137: No new images detected: nothing to do! |
What does this PR do?
expires_in
value, see: https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/refreshing-user-access-tokens#refreshing-a-user-access-token-with-a-refresh-tokenrefreshToken
function for Azure DevOps. The existed refresh function from theoauth2
package fails because Azure DevOps supports POST requests inapplication/x-www-form-urlencoded
format only.Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23028
How to test this PR?
see eclipse-che/che#23028
Same steps are relevant for Azure DevOps
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.