-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow to configure 2 gitlab providers simultaneously #731
Conversation
Should be fixed by the dashboard pull request fixup. |
Verified on Eclipse Che with gitlab server and GitLab.com using
The functionality works properly. Verification with two gitlab servers is still in progress. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: artaleks9, tolusha, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.18 :: server_3.x/367: Console, Changes, Git Data |
Build 3.18 :: sync-to-downstream_3.x/7929: Console, Changes, Git Data |
Build 3.18 :: push-latest-container-to-quay_3.x/5010: Console, Changes, Git Data |
Build 3.18 :: get-sources-rhpkg-container-build_3.x/7989: server : 3.x :: Build 65453780 : quay.io/devspaces/server-rhel8:3.18-6 |
Build 3.18 :: server_3.x/367: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7929 triggered |
Build 3.18 :: update-digests_3.x/7865: Console, Changes, Git Data |
Build 3.18 :: operator-bundle_3.x/3743: Console, Changes, Git Data |
Build 3.18 :: sync-to-downstream_3.x/7931: Console, Changes, Git Data |
Build 3.18 :: get-sources-rhpkg-container-build_3.x/7991: devspaces-operator-bundle : 3.x :: Failed in 65455836 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
Allow to configure 2 gitlab providers simultaneously
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-7142
How to test this PR?
che-server
image:quay.io/eclipse/che-server:pr-731
che-operator
image:quay.io/ivinokur/che-operator:next
che-dashboard
image:quay.io/eclipse/che-dashboard:pr-1237
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedRelease Notes
With this feature it is possible to configure two Gitlab oauth providers simultaneously.
Reviewers
Reviewers, please comment how you tested the PR when approving it.