Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not validate Bitbucket Server by Api request #757

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vinokurig
Copy link
Contributor

What does this PR do?

Remove the 'isApiRequestRelevant()' function from the Bitbucket Server flow. The function tests the given url if it belongs to Bitbucket Server by doing a user request. Bitbucket Server returns an empty string for unauthorized user without any specific messages. This is a problem as other unsupported git services might work in the same way, so we can not relay on that because if some unsupported git service also returns an empty string on an unsupported api request, the function will incorrectly mark the given url as Bitbucket Server.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#23303

How to test this PR?

see eclipse-che/che#23303

PR Checklist

As the author of this Pull Request I made sure that:

Release Notes

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Copy link

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jan 23, 2025

@vinokurig: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-bitbucket-no-pat-oauth-flow 5c2963a link true /test v14-bitbucket-no-pat-oauth-flow
ci/prow/v14-che-smoke-test 5c2963a link true /test v14-che-smoke-test
ci/prow/v14-github-no-pat-oauth-flow-raw-devfile-url 5c2963a link true /test v14-github-no-pat-oauth-flow-raw-devfile-url

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant