fix: workspaces must not fail on metrics roles creation when APi is disabled or unauthorized #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
mshaposhnik
requested review from
amisevsk,
metlos,
nickboldt,
skabashnyuk and
sleshchenko
as code owners
mshaposhnik
changed the title
mshaposhnik
requested review from
sparkoo
and removed request for
nickboldt,
sleshchenko and
amisevsk
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
|
❌ E2E Happy path tests failed ❗ See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
sparkoo
approved these changes
Sep 1, 2021
skabashnyuk
approved these changes
Sep 1, 2021
mshaposhnik
changed the title
mshaposhnik
added a commit
to mshaposhnik/che-server
that referenced
this pull request
Sep 3, 2021
…isabled or unauthorized (eclipse-che#93) Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Workspace namespace is not prepared properly and startup is broken if
metrics.k8s.ioAPI is not enabled on the cluster or Che SA cannot create appropriate roles due to lack of permissions.Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-2202
eclipse-che/che#19869
How to test this PR?
Run minishift 3.11 with metrica API disabled. User is unable to start any workspaces;
Chenge image to
mshaposh/che-server:nightly. Workspaces run ok.PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.