fix: Correct previous roles validation fixup for minikube #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
mshaposhnik
requested review from
amisevsk,
metlos,
nickboldt,
skabashnyuk and
sleshchenko
as code owners
sparkoo
approved these changes
Sep 2, 2021
|
❌ E2E Happy path tests failed ❗ See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
skabashnyuk
approved these changes
Sep 3, 2021
mshaposhnik
added a commit
to mshaposhnik/che-server
that referenced
this pull request
Sep 3, 2021
…he#94) Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
benoitf
changed the title
|
❌ E2E Happy path tests failed ❗ See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Correct prervious roles validation fixup for minikube as minikube may not allow to acccess "/" endpoint to check installed API-s.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#20401
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.