This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
feat(resource-monitor-plugin): Update to latest devfile 2 API #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
ericwill,
sunix,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
benoitf
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1018 +/- ##
=======================================
Coverage 64.72% 64.72%
=======================================
Files 68 68
Lines 2466 2466
Branches 391 391
=======================================
Hits 1596 1596
Misses 860 860
Partials 10 10
Continue to review full report at Codecov.
|
benoitf
force-pushed
the
resource-monitor-plugin-devfile2
branch
from
b3dd619 to
af487c5
Compare
Change-Id: Ia532b973e081ae9801cd28008521bd07db9411fa Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
force-pushed
the
resource-monitor-plugin-devfile2
branch
from
af487c5 to
4a386c5
Compare
|
✅ E2E Happy path tests succeed 🎉
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
svor
approved these changes
Mar 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Switch API call to get devfile attributes.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#19188
How to test this PR?
Should work as before for the resource monitor plug-in
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=next
Change-Id: Ia532b973e081ae9801cd28008521bd07db9411fa
Signed-off-by: Florent Benoit fbenoit@redhat.com