Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

feat(workspace-plugin): Update to new devfile 2.0 API #1021

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Mar 8, 2021

What does this PR do?

Use new devfile 2.0 definition of projects (several remotes, multiple sparse checkout directories, etc)

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#19188

How to test this PR?

Look at how che-theia clone projects (different config like: from a zip file, from git, using or not sparseCheckout)

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=next

Change-Id: I58180b164923b9b14148d09f890e8e6d3d78b855
Signed-off-by: Florent Benoit fbenoit@redhat.com

@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #1021 (ab25799) into master (0753a13) will increase coverage by 0.87%.
The diff coverage is 39.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1021      +/-   ##
==========================================
+ Coverage   18.02%   18.89%   +0.87%     
==========================================
  Files         296      296              
  Lines       11114    11057      -57     
  Branches     1699     1680      -19     
==========================================
+ Hits         2003     2089      +86     
+ Misses       8963     8818     -145     
- Partials      148      150       +2     
Impacted Files Coverage Δ
...orkspace-plugin/src/ephemeral-workspace-checker.ts 0.00% <0.00%> (ø)
plugins/workspace-plugin/src/git.ts 54.09% <0.00%> (ø)
...workspace-plugin/src/workspace-projects-manager.ts 0.00% <0.00%> (ø)
plugins/workspace-plugin/src/theia-commands.ts 43.35% <69.81%> (+43.35%) ⬆️
plugins/workspace-plugin/src/projects.ts 87.87% <71.42%> (+35.41%) ⬆️
plugins/task-plugin/src/che-workspace-client.ts 0.00% <0.00%> (ø)
plugins/workspace-plugin/src/ssh.ts 33.33% <0.00%> (+33.33%) ⬆️
plugins/workspace-plugin/src/ca-cert.ts 40.00% <0.00%> (+40.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0753a13...ab25799. Read the comment docs.

@che-bot

This comment has been minimized.

@che-bot

This comment has been minimized.

@benoitf benoitf force-pushed the workspace-plugin branch 2 times, most recently from 2f40cb5 to c9391d9 Compare March 8, 2021 15:09
@che-bot

This comment has been minimized.

@che-bot

This comment has been minimized.

@benoitf benoitf marked this pull request as ready for review March 8, 2021 17:09
@che-bot
Copy link
Contributor

che-bot commented Mar 8, 2021

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1021
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1021

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@che-bot

This comment has been minimized.

Change-Id: I58180b164923b9b14148d09f890e8e6d3d78b855
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@che-bot

This comment has been minimized.

@benoitf
Copy link
Contributor Author

benoitf commented Mar 9, 2021

[crw-ci-test]

@che-bot

This comment has been minimized.

@benoitf
Copy link
Contributor Author

benoitf commented Mar 9, 2021

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Mar 9, 2021

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1021
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1021

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@vitaliy-guliy
Copy link
Contributor

Code looks well, checking the behavior..

Copy link
Contributor

@vitaliy-guliy vitaliy-guliy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have just tested. Works fine with this devfile

---
apiVersion: 1.0.0
metadata:
  generateName: clone-ssh-
projects:
  -
    name: greeting-extension
    source:
      type: git
      location: "git@github.com:eclipse/che-theia.git"
  -
    name: atlascode
    source:
      type: git
      location: "git@bitbucket.org:atlassianlabs/atlascode.git"
components:
  - type: cheEditor
    alias: che-theia
    reference: https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1021/che_theia_meta.yaml
    memoryLimit: 512Mi

@benoitf
Copy link
Contributor Author

benoitf commented Mar 10, 2021

I'll merge in a couple of hours if there is no objection

@benoitf benoitf merged commit bc0fce1 into eclipse-che:master Mar 10, 2021
@benoitf benoitf deleted the workspace-plugin branch March 10, 2021 12:37
@che-bot che-bot added this to the 7.28 milestone Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants