-
Notifications
You must be signed in to change notification settings - Fork 111
feat(workspace-plugin): Update to new devfile 2.0 API #1021
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1021 +/- ##
==========================================
+ Coverage 18.02% 18.89% +0.87%
==========================================
Files 296 296
Lines 11114 11057 -57
Branches 1699 1680 -19
==========================================
+ Hits 2003 2089 +86
+ Misses 8963 8818 -145
- Partials 148 150 +2
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
2b74ed1
to
39392c6
Compare
This comment has been minimized.
This comment has been minimized.
2f40cb5
to
c9391d9
Compare
This comment has been minimized.
This comment has been minimized.
c9391d9
to
c9de822
Compare
This comment has been minimized.
This comment has been minimized.
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
c9de822
to
9913fbb
Compare
This comment has been minimized.
This comment has been minimized.
9913fbb
to
828f8ef
Compare
Change-Id: I58180b164923b9b14148d09f890e8e6d3d78b855 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
828f8ef
to
ab25799
Compare
This comment has been minimized.
This comment has been minimized.
[crw-ci-test] |
This comment has been minimized.
This comment has been minimized.
[crw-ci-test] |
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
Code looks well, checking the behavior.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have just tested. Works fine with this devfile
---
apiVersion: 1.0.0
metadata:
generateName: clone-ssh-
projects:
-
name: greeting-extension
source:
type: git
location: "git@github.com:eclipse/che-theia.git"
-
name: atlascode
source:
type: git
location: "git@bitbucket.org:atlassianlabs/atlascode.git"
components:
- type: cheEditor
alias: che-theia
reference: https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1021/che_theia_meta.yaml
memoryLimit: 512Mi
I'll merge in a couple of hours if there is no objection |
What does this PR do?
Use new devfile 2.0 definition of projects (several remotes, multiple sparse checkout directories, etc)
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#19188
How to test this PR?
Look at how che-theia clone projects (different config like: from a zip file, from git, using or not sparseCheckout)
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=next
Change-Id: I58180b164923b9b14148d09f890e8e6d3d78b855
Signed-off-by: Florent Benoit fbenoit@redhat.com