This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
feat(ports-plugin): Handle devworkspaces #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[crw-ci-test --rebuild] |
1 similar comment
|
[crw-ci-test --rebuild] |
|
✅ E2E Happy path tests succeed 🎉
See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
benoitf
force-pushed
the
ports-plugin-devfilev2
branch
2 times, most recently
from
a6dae07 to
a5fe9aa
Compare
Codecov Report
@@ Coverage Diff @@
## master #1129 +/- ##
==========================================
+ Coverage 29.45% 32.65% +3.20%
==========================================
Files 277 286 +9
Lines 9336 9725 +389
Branches 1380 1473 +93
==========================================
+ Hits 2750 3176 +426
+ Misses 6487 6451 -36
+ Partials 99 98 -1
Continue to review full report at Codecov.
|
|
✅ E2E Happy path tests succeed 🎉
See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
|
✅ E2E Happy path tests succeed 🎉
See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
benoitf
force-pushed
the
ports-plugin-devfilev2
branch
from
a5fe9aa to
ecf7af3
Compare
|
✅ E2E Happy path tests succeed 🎉
See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Change-Id: I67d3d67dd52d9ec6a0b12b7aeeb65f7bdf34d801 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
force-pushed
the
ports-plugin-devfilev2
branch
from
ecf7af3 to
268b004
Compare
|
✅ E2E Happy path tests succeed 🎉
See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
benoitf
requested review from
ericwill,
sunix,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
sunix
approved these changes
Jun 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for devworkspaces in ports-plugin
For now when starting a devWorkspace we have a failure saying that extension can't read machines field (which is only che-server implementation)
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#19188
How to test this PR?
Start devWorkspace with che-theia and see that ports-plugin display endpoints
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=next
Change-Id: I67d3d67dd52d9ec6a0b12b7aeeb65f7bdf34d801
Signed-off-by: Florent Benoit fbenoit@redhat.com