Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

build: Fix build of Che-Theia and ci jobs for happy path tests #1157

Merged
merged 2 commits into from
Jul 6, 2021

Conversation

RomanNikitenko
Copy link
Member

@RomanNikitenko RomanNikitenko commented Jul 2, 2021

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

What does this PR do?

  • There are breaking changes in upstream after merging the changes related to upgrade Monaco version.
    The current PR pins Che-Theia to upstream Theia before the breaking changes.
  • use 1.21.0 version of minikube for happy path tests

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#20069
eclipse-che/che#20076

How to test this PR?

The build should pass successfully.
The tests should be happy.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=next

@RomanNikitenko RomanNikitenko changed the title Pin Che-Theia to upstream Theia before the breaking changes build: Pin Che-Theia to upstream Theia before the breaking changes Jul 2, 2021
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #1157 (4b8b2ae) into main (c299f59) will decrease coverage by 0.11%.
The diff coverage is 9.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1157      +/-   ##
==========================================
- Coverage   32.78%   32.67%   -0.12%     
==========================================
  Files         290      290              
  Lines        9885     9922      +37     
  Branches     1457     1526      +69     
==========================================
+ Hits         3241     3242       +1     
+ Misses       6641     6580      -61     
- Partials        3      100      +97     
Impacted Files Coverage Δ
...eia-workspace/src/browser/che-navigator-widget.tsx 0.00% <0.00%> (ø)
...heia-workspace/src/browser/che-workspace-module.ts 0.00% <0.00%> (ø)
...ns-plugin/src/strategy/featured-plugin-strategy.ts 100.00% <100.00%> (ø)
generator/src/json-utils.ts 25.00% <0.00%> (ø)
plugins/task-plugin/src/utils.ts 0.00% <0.00%> (ø)
plugins/ssh-plugin/src/util/util.ts 0.00% <0.00%> (ø)
plugins/workspace-plugin/src/git.ts 54.09% <0.00%> (ø)
plugins/workspace-plugin/src/ssh.ts 30.00% <0.00%> (ø)
plugins/ssh-plugin/src/ssh-plugin.ts 0.00% <0.00%> (ø)
plugins/welcome-plugin/src/welcome-page.ts 0.00% <0.00%> (ø)
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10bb2e7...4b8b2ae. Read the comment docs.

@che-bot

This comment has been minimized.

@RomanNikitenko
Copy link
Member Author

[crw-ci-test]

@che-bot

This comment has been minimized.

@RomanNikitenko

This comment has been minimized.

@che-bot

This comment has been minimized.

@RomanNikitenko

This comment has been minimized.

@RomanNikitenko

This comment has been minimized.

@che-bot

This comment has been minimized.

@RomanNikitenko
Copy link
Member Author

[crw-ci-test --rebuild]

1 similar comment
@RomanNikitenko
Copy link
Member Author

[crw-ci-test --rebuild]

@RomanNikitenko
Copy link
Member Author

depends on eclipse-che/che#20076

@dmytro-ndp

This comment has been minimized.

@che-bot

This comment has been minimized.

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Jul 5, 2021

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1157
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1157

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@RomanNikitenko RomanNikitenko changed the title build: Pin Che-Theia to upstream Theia before the breaking changes build: Fix build of Che-Theia and ci jobs for happy path tests Jul 6, 2021
@RomanNikitenko RomanNikitenko merged commit 9f2aaf9 into eclipse-che:main Jul 6, 2021
@RomanNikitenko RomanNikitenko deleted the pinCheTheia branch July 6, 2021 07:48
@che-bot che-bot added this to the 7.33 milestone Jul 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants