This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
build: Fix build of Che-Theia and ci jobs for happy path tests #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanNikitenko
changed the title
Pin Che-Theia to upstream Theia before the breaking changes
build: Pin Che-Theia to upstream Theia before the breaking changes
Jul 2, 2021
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
RomanNikitenko
force-pushed
the
pinCheTheia
branch
from
July 2, 2021 13:32
1bd69fd
to
4e4c724
Compare
Codecov Report
@@ Coverage Diff @@
## main #1157 +/- ##
==========================================
- Coverage 32.78% 32.67% -0.12%
==========================================
Files 290 290
Lines 9885 9922 +37
Branches 1457 1526 +69
==========================================
+ Hits 3241 3242 +1
+ Misses 6641 6580 -61
- Partials 3 100 +97
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
[crw-ci-test] |
benoitf
approved these changes
Jul 2, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[crw-ci-test --rebuild] |
1 similar comment
[crw-ci-test --rebuild] |
3 tasks
depends on eclipse-che/che#20076 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
❌ E2E Happy path tests failed ❗ See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
23 tasks
benoitf
approved these changes
Jul 6, 2021
RomanNikitenko
changed the title
build: Pin Che-Theia to upstream Theia before the breaking changes
build: Fix build of Che-Theia and ci jobs for happy path tests
Jul 6, 2021
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roman Nikitenko rnikiten@redhat.com
What does this PR do?
Monaco
version.The current PR pins
Che-Theia
to upstreamTheia
before the breaking changes.Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#20069
eclipse-che/che#20076
How to test this PR?
The build should pass successfully.
The tests should be happy.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=next