This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
chore: Per Florent's explanation, let's tag if can pull; else skip. This is just a performance enhancement to reuse unchanged layers when building che-theia-dev, not an indicator to SKIP the che-theia-dev build. #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
@@ Coverage Diff @@
## main #1216 +/- ##
==========================================
- Coverage 32.78% 32.69% -0.10%
==========================================
Files 290 295 +5
Lines 9885 10005 +120
Branches 1457 1550 +93
==========================================
+ Hits 3241 3271 +30
+ Misses 6641 6625 -16
- Partials 3 109 +106
Continue to review full report at Codecov.
|
|
✅ E2E Happy path tests succeed 🎉
See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
|
PR check running in https://app.travis-ci.com/github/eclipse-che/che-theia/builds/237545007 But has already failed for a few arch combos:
|
nickboldt
force-pushed
the
dummy-pr-test-19688
branch
from
9ab53de to
ba902ac
Compare
|
Good news: node build on s390x passed. Bad news: all the container builds failed or errored. Possible fix: ba902ac |
nickboldt
changed the title
…his is just a performance enhancement to reuse unchanged layers when building che-theia-dev, not an indicator to SKIP the che-theia-dev build. Change-Id: I9bd488c936026b8fd26cd21b8301a81fc022a61f Signed-off-by: nickboldt <nboldt@redhat.com>
nickboldt
force-pushed
the
dummy-pr-test-19688
branch
from
ba902ac to
48e04bb
Compare
nickboldt
changed the title
benoitf
approved these changes
Sep 13, 2021
|
❌ E2E Happy path tests failed ❗
See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
chore: Per Florent's explanation, let's tag if can pull; else skip. This is just a performance enhancement to reuse unchanged layers when building che-theia-dev, not an indicator to SKIP the che-theia-dev build.
Change-Id: I2f8a2c2eaecc68aad3a1e5f034bc7093d610e489
Signed-off-by: nickboldt nboldt@redhat.com
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
N/A (or see commit message above for issue number)
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.