This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
fix: Plugins without sidecars were not injected #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
azatsarynnyy,
RomanNikitenko and
vzhukovs
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1248 +/- ##
==========================================
- Coverage 32.78% 32.67% -0.11%
==========================================
Files 290 296 +6
Lines 9885 9872 -13
Branches 1457 1327 -130
==========================================
- Hits 3241 3226 -15
- Misses 6641 6642 +1
- Partials 3 4 +1
Continue to review full report at Codecov.
|
svor
reviewed
Nov 4, 2021
There was a problem hiding this comment.
Works with the sample described in the issue:
Also tried with scala sample: https://github.com/svor/scala-sbt/tree/devfile2 (contains 2 extensions, one of them without sidecar):
Works as expected!
|
✅ E2E Happy path tests succeed 🎉
See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
This comment has been minimized.
This comment has been minimized.
svor
approved these changes
Nov 4, 2021
At the beginning, theia component was part of the devWorkspace and then we had access to the atttributes from the DevWorkspace object Now, it's part of the devWorkspaceTemplate object Switch to the flattened devfile instead so nothing to query externally Also, in order to reduce sed usage, use jq/yq instead as there was also a bug on empty list Added some unit tests as well Change-Id: Ic8b417484596f8440a157e0d24cd7bbf4da9c40c Signed-off-by: Florent Benoit <fbenoit@redhat.com>
…ng, theia component was part of the devWorkspace and then we had access to the atttributes from the DevWorkspace object Now, it's part of the devWorkspaceTemplate object Change-Id: I75d55afc97f4888d4c77a307aa25b7776b308f73 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
azatsarynnyy
approved these changes
Nov 5, 2021
|
✅ E2E Happy path tests succeed 🎉
See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
At the beginning, theia component was part of the devWorkspace and then we
had access to the atttributes from the DevWorkspace object
Now, it's part of the devWorkspaceTemplate object
Switch to the flattened devfile instead so nothing to query externally
Also, in order to reduce sed usage, use jq/yq instead as there was also a bug
on empty list
Added some unit tests as well
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#20718
How to test this PR?
Start the workspace from the issue
Eslint should not be there (check output widget inside theia or command palette)
if you check the logs of the init container you might as well see tons of errors
Open a terminal and drop anything located inside /plugins folder
Edit the DevWorkspaceTemplate object
Search for the
remote-runtimecomponentand replace the default image by
quay.io/fbenoit/che-theia-endpoint-runtime-binary:20211104crestart the workspace
eslint should be there
Also you might check the log trace of the init-container and see something like
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=next
Change-Id: Ic8b417484596f8440a157e0d24cd7bbf4da9c40c
Signed-off-by: Florent Benoit fbenoit@redhat.com