Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

feat: devWorkspaces: Add link to dashboard, implement stop #1264

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Nov 22, 2021

What does this PR do?

  • Add a link to dashboard in command palette for DevWorkspace mode
  • Implement the stopWorkspace method (instead of current throwing 'not implemented' error) of a DevWorkspace
  • Redirect to the dashboard page when closing the Workspace in DevWorkspace mode (today it's doing nothing. workspace is not stopped and we stay in the IDE page)

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Fixes eclipse-che/che#20808

How to test this PR?

In DevWorkspace mode:
open a getting started, check there is a link in command palette to open dashboard and you can open dashboard
close the workspace and check we're redirected to dashboard
you can try with:
https://<che-host-with-devworkspace>#https://github.com/che-samples/java-spring-petclinic/tree/devfilev2?che-editor=https://gist.githubusercontent.com/benoitf/8603992a73e902792b8961c645395897/raw/619f4ae4b29dfdb27e016e73353715050c75d4f1/pr1264-theia.yaml

in che-server-mode:
check open dashboard command is NOT in command palette (it's only for DevWorkspace mode)
Try to use menu "close workspace", it should display again the workspaces as before (we stay in dashboard)

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=next

Change-Id: I55672c6ed1b8933e921d85f8bcb956f127680cf6
Signed-off-by: Florent Benoit fbenoit@redhat.com

@che-bot

This comment has been minimized.

@codecov

This comment has been minimized.

@che-bot

This comment has been minimized.

Fixes eclipse-che/che#20808

Change-Id: I55672c6ed1b8933e921d85f8bcb956f127680cf6
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Nov 23, 2021

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1264
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1264

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@benoitf benoitf marked this pull request as ready for review November 24, 2021 07:37
@benoitf benoitf changed the title feat: Add links to dashboard feat: devWorkspaces: Add link to dashboard, implement stop Nov 24, 2021
@benoitf benoitf merged commit 8a48c2f into eclipse-che:main Nov 26, 2021
@benoitf benoitf deleted the CHE-20808 branch November 26, 2021 09:07
@che-bot che-bot added this to the 7.40 milestone Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing link to Che dashboard in Che-Theia in DevWorkspace mode
3 participants