This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
feat: devWorkspaces: Add link to dashboard, implement stop #1264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Fixes eclipse-che/che#20808
How to test this PR?
In DevWorkspace mode:
open a getting started, check there is a link in command palette to open dashboard and you can open dashboard
close the workspace and check we're redirected to dashboard
you can try with:
https://<che-host-with-devworkspace>#https://github.com/che-samples/java-spring-petclinic/tree/devfilev2?che-editor=https://gist.githubusercontent.com/benoitf/8603992a73e902792b8961c645395897/raw/619f4ae4b29dfdb27e016e73353715050c75d4f1/pr1264-theia.yaml
in che-server-mode:
check open dashboard command is NOT in command palette (it's only for DevWorkspace mode)
Try to use menu "close workspace", it should display again the workspaces as before (we stay in dashboard)
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=next
Change-Id: I55672c6ed1b8933e921d85f8bcb956f127680cf6
Signed-off-by: Florent Benoit fbenoit@redhat.com