This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
[WIP] Remove synchronous logic from generator requests #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksii Orel <oorel@redhat.com>
olexii4
requested review from
davidfestal,
evidolob,
vitaliy-guliy,
mmorhun and
akurinnoy
|
I reworked the implementation for some part of the code and tests. But I stuck with "resourceUrl". It seems cannot be asynchronous. It should be discussed. |
benoitf
reviewed
Aug 1, 2019
| } | ||
| vsLoader(context: any): void { | ||
| const loaderURL = this.url(this.info.monaco.vsLoader.cdn, this.info.monaco.vsLoader.external); | ||
| async vsLoader(context: any): Promise<void> { |
There was a problem hiding this comment.
AFAIK this method can't be asynchronous
|
@olexii4 I don't think I'll be able to work on this before Che 7 GA, due to time constraints / vacations. |
vinokurig
pushed a commit
that referenced
this pull request
Apr 6, 2021
Signed-off-by: svor <vsvydenk@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleksii Orel oorel@redhat.com
What does this PR do?
Remove synchronous logic from generator requests. Improve the algorithm. Fix tests.
What issues does this PR fix or reference?
eclipse-che/che#14039
Release Notes
Docs PR